Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUPLO-20879 Fallback implemented #642

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sp1676
Copy link
Contributor

@sp1676 sp1676 commented Aug 26, 2024

User description

Reverts #641


PR Type

enhancement, bug fix


Description

  • Implemented a fallback mechanism for handling DynamoDB table retrieval and deletion errors, improving robustness.
  • Enhanced logging to provide more detailed error messages for debugging.
  • Updated the logic to handle short names in DynamoDB table operations.
  • Updated the CHANGELOG to reflect the reintroduction of the fallback mechanism.

Changes walkthrough 📝

Relevant files
Enhancement
resource_duplo_aws_dynamodb_table_v2.go
Add fallback mechanism and improve error handling in DynamoDB
operations

duplocloud/resource_duplo_aws_dynamodb_table_v2.go

  • Implemented a fallback mechanism for DynamoDB table retrieval and
    deletion.
  • Enhanced error logging for better debugging.
  • Adjusted logic to handle short names in table operations.
  • +29/-10 
    Documentation
    CHANGELOG.md
    Update CHANGELOG to reflect current changes                           

    CHANGELOG.md

    • Removed previous entry about removing fallback mechanism.
    +0/-5     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @sp1676 sp1676 requested a review from a team as a code owner August 26, 2024 20:58
    @qodo-merge-pro qodo-merge-pro bot added enhancement New feature or request Bug fix labels Aug 26, 2024
    Copy link
    Contributor

    PR Description updated to latest commit (31c7751)

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Error Handling
    The fallback mechanism might mask underlying issues. Consider adding more specific error checks before falling back.

    Code Duplication
    Similar fallback logic is repeated in multiple functions. Consider extracting this into a helper function.

    Comment on lines 1 to +4
    ## 2024-08-26

    ### Fixed
    - Removed fallback mechanism for error handling in DynamoDB table operations, simplifying code and improving maintainability.
    ### Enhanced
    - Reintroduced fallback mechanism for error handling in DynamoDB table operations, improving robustness and error logging.
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    CHANGELOG.md update

    @sp1676 sp1676 added the do not merge Don't merge this PR. label Aug 30, 2024
    Copy link
    Contributor

    @Duplo-nikv Duplo-nikv left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Bug fix do not merge Don't merge this PR. enhancement New feature or request Review effort [1-5]: 2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants