-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rusk-wallet: Implement moonlight history #3284
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be possible to have a tx history containing both Phoenix and moonlight transactions?
Why did you split them?
Additionally (but not blockers):
- try to store the history in rocksdb to improve performance and unload archival computation (we already store Notes, you only miss the derived TransactionHistory objects)
- add a warning if the user is not connected to an archival
Mixing the moonlight and phoenix tx history would be confusing no? I can add another column that displays transaction type but that would add more info and make it harder to read I split the history because all other methods are also split on public/private it makes sense. Can you create issue for those two points you mentioned? |
In the long run, I think it is necessary to add such a column anyway. Because we want to differentiate between different types of transactions (transfer out, transfer in, conversion, deposit, withdrawal, etc.). |
These infos are already available in the transaction history in the "method" column IIRC |
@herr-seppia I merged them both and made another PR for pagenation |
dd3f285
to
3f6349c
Compare
a92924b
to
5426767
Compare
5426767
to
7d66a52
Compare
Closes #2271