feat(ui): non-closeable modal support #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceisipeik
approved these changes
Oct 28, 2024
ceisipeik
reviewed
Oct 28, 2024
| <cvi-ng-icon [name]="'close'" [height]="14"></cvi-ng-icon> | ||
| </button> | ||
| <ng-template [ngTemplateOutlet]="templateRef" [ngTemplateOutletContext]="{ $implicit: this, title }"></ng-template> | ||
| </div> | ||
| <div class="cvi-modal__backdrop" dataAttribute="modal-backdrop" (click)="closeModal()"></div> | ||
| <div class="cvi-modal__backdrop" dataAttribute="modal-backdrop" (click)="closeable && closeModal()"></div> |
There was a problem hiding this comment.
maybe move the closeable check into the closeModal() method?
ceisipeik
approved these changes
Oct 28, 2024
certainlyakey
requested changes
Oct 28, 2024
| @@ -15,7 +15,7 @@ export const Default = { | |||
| <h1>{{ testModalTitle }}</h1> | |||
| <p dataAttribute="test-content">Modal content</p> | |||
| </ng-template> | |||
| <cvi-ng-button [cviNgModal]="modal" modalTitle="Some title" dataAttribute="test-button">Open modal</cvi-ng-button> | |||
| <cvi-ng-button [cviNgModal]="modal" modalTitle="Some title" closeable="true" dataAttribute="test-button">Open modal</cvi-ng-button> | |||
There was a problem hiding this comment.
Same as in confirmation-modal.component.stories.ts, this attribute probably should be turned into a live Storybook control using a closeable arg:
Suggested change
| <cvi-ng-button [cviNgModal]="modal" modalTitle="Some title" closeable="true" dataAttribute="test-button">Open modal</cvi-ng-button> | |
| <cvi-ng-button [cviNgModal]="modal" modalTitle="Some title" [closeable]="closeable" dataAttribute="test-button">Open modal</cvi-ng-button> |
| @@ -17,6 +17,7 @@ export class ModalComponent implements OnDestroy { | |||
| templateRef!: TemplateRef<any>; | |||
|
|
|||
| title!: string; | |||
| closeable!: boolean; | |||
There was a problem hiding this comment.
Should the prop have a default value?
There was a problem hiding this comment.
I'll put it to true so those that are using it directly wouldn't have to change anything to have same function they have right now
certainlyakey
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.