Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use leadership_expiry_ to deem nodes unhealthy #523

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Use leadership_expiry_ to deem nodes unhealthy #523

merged 2 commits into from
Jul 30, 2024

Conversation

antoniofilipovic
Copy link
Contributor

Opening PR as per issue #522

greensky00
greensky00 reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@greensky00 greensky00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a couple of minor comments.

src/raft_server.cxx Outdated Show resolved Hide resolved
src/raft_server.cxx Outdated Show resolved Hide resolved
greensky00
greensky00 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@greensky00 greensky00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@greensky00 greensky00 merged commit bd8fb29 into eBay:master Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greensky00 greensky00 greensky00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoniofilipovic @greensky00