Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix it with workable html2canvas version #676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LarryMckuydee
Copy link

Changes:

  • Downgrade html2canvas to eKoopmans-html2canvas-v0.5.0-beta4-33-g420d08a.tar.gz version
  • Upgrade jspdf to 2.5.1 to avoid vulnerabilities

Note:

  • Tested able to generate pdf without overlay and blank page issue

Upgrade jspdf to 2.5.1 to avoid vulnerabilities

Note:
- Tested able to generate pdf without overlay and blank page issue
@LarryMckuydee
Copy link
Author

Hi @eKoopmans ,

Thank you for developing such an awesome plugin! It has been a huge time-saver for me in calculating page breaks and generating PDFs.

I noticed from your README.md that version v0.10.1 is facing some issues, and the currently available stable version is v0.9.3. However, even in v0.9.3, I've observed some issues with page breaks, particularly overlay problems. Though it's not as severe as in v0.10.1, where it caused blank PDF pages and overlay issues simultaneously.

After hours of debugging, I traced the issue back to html2canvas. The version of html2canvas mentioned above seems to be the best available option for me, providing accurate page breaks and maintaining good image quality.

I won't delve into the details of the features or functions that the latest version of html2canvas may offer, but this version works perfectly for my needs. Feel free to ignore this pull request, as I'm unaware of the future direction for html2pdf, and I understand you may have your own considerations for what will work best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant