Add audio to epub js #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: replacing the smil urls with one less folder reference (getting rid of the ../) made the audio load correctly. Not sure best way to solve this. Should we modify the original files?
arsduo
reviewed
Sep 27, 2022
| @@ -19,73 +21,74 @@ | |||
|
|
|||
| <script> | |||
|
|
|||
| var book = ePub(); | |||
| var rendition; | |||
| var book = ePub(); | |||
There was a problem hiding this comment.
Looks like this PR has a lot formatting commits from the editor, which makes it really hard to read.
I wonder if there's a way to revert them (since these changes probably wouldn't be accepted by the upstream repo), or if that's too hard. If we do keep them, could we do a PR that just touches these files to get the formatting changes, merge that in, and then have a PR that's only the changes we want for audio?
|
@kmacshane should we merge this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit for adding audio files. Currently it will load the smil files but the URLs are erroring out.