Added a Fs check between source and function input #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a different Fs value as an input parameter in the 'simulate_measuremente_mvs.m' then the Fs value of the source will result in an error that doesn't give many details. Therefore, was added a if statement that raises an error if the Fs values doesn't match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a different Fs value in the function 'simulate_measuremente_mvs' would lead to an error when trying to create the Audio. The standard error raised by Matlab would not give many details on what is precisely the problem. Therefore, it was added a statement that checks the values and informs (as an error) that the values don't match. This will allow the user to verify the correct Fs to be used when trying to use the function 'simulate_measuremente_mvs'.