Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test unification #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Test unification #21

wants to merge 4 commits into from

Conversation

eapolinario
Copy link
Owner

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 68.44920% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 59.00%. Comparing base (bcd81b6) to head (ba29171).

Files Patch % Lines
flyteadmin/pkg/rpc/adminservice/project.go 0.00% 15 Missing ⚠️
flyteadmin/dataproxy/service.go 56.52% 9 Missing and 1 partial ⚠️
...asks/pluginmachinery/flytek8s/k8s_resource_adds.go 28.57% 8 Missing and 2 partials ⚠️
...ytepropeller/pkg/controller/nodes/array/handler.go 65.38% 8 Missing and 1 partial ⚠️
flytestdlib/storage/stow_store.go 78.94% 3 Missing and 1 partial ⚠️
...g/executioncluster/impl/random_cluster_selector.go 85.00% 2 Missing and 1 partial ⚠️
flyteadmin/pkg/manager/impl/execution_manager.go 90.00% 2 Missing and 1 partial ⚠️
flyteadmin/pkg/common/filters.go 60.00% 2 Missing ⚠️
flytestdlib/storage/mem_store.go 0.00% 2 Missing ⚠️
flytepropeller/pkg/controller/controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           master      #21    +/-   ##
========================================
  Coverage   59.00%   59.00%            
========================================
  Files         645      645            
  Lines       55551    55674   +123     
========================================
+ Hits        32779    32852    +73     
- Misses      20181    20226    +45     
- Partials     2591     2596     +5     
Flag Coverage Δ
unittests 59.00% <68.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants