Support node18 (#3098)

* chore: support node v18 again due to http bug in v19 * chore: fixing ci run fails with package-lock.json * ci: npm audit fix website/package-lock.json * chore: fix some typos in comment (#3094) Signed-off-by: deterclosed <[email protected]> * chore(releng) bump version to 20.1.2 --------- Signed-off-by: deterclosed <[email protected]> Co-authored-by: deterclosed <[email protected]>
ecadlabs · Dec 18, 2024 · 1b4e1de · 1b4e1de
1 parent 2a55d6f
commit 1b4e1de
Show file tree

Hide file tree

Showing 57 changed files with 459 additions and 428 deletions.
diff --git a/.github/workflows/bundle_webpack.yml b/.github/workflows/bundle_webpack.yml
@@ -17,7 +17,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: lts/iron
+          node-version: lts/Hydrogen
       - run: npm ci
       - run: npm run build
       - run: npm -w packages/taquito-local-forging run build-webpack

diff --git a/.github/workflows/deploy_edge.yml b/.github/workflows/deploy_edge.yml
@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: lts/iron
+          node-version: lts/Hydrogen
       - run: echo "SHORT_SHA=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
       - run: echo "PACKAGE_VERSION=`node -p "require('./packages/taquito/package.json').version"`" >> $GITHUB_ENV
       - run: echo "BRANCH_NAME=$(git branch --show-current)" >> $GITHUB_ENV

diff --git a/.github/workflows/deploy_test_dapp.yml b/.github/workflows/deploy_test_dapp.yml
@@ -21,7 +21,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: lts/iron
+          node-version: lts/Hydrogen
       - run: npm ci
       - run: npm run build
       - run: npm -w taquito-test-dapp-vite run build

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -17,8 +17,9 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 'lts/iron'
-          - '22'
+          - 'lts/Hydrogen'
+          - 'lts/Iron'
+          - 'lts/Jod'
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
@@ -49,7 +50,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: lts/iron
+          node-version: lts/Hydrogen
       - run: npm ci
       - run: npm run build
       - if: ${{ !github.event.pull_request.head.repo.fork }}

diff --git a/.github/workflows/mondaynet.yml b/.github/workflows/mondaynet.yml
@@ -39,7 +39,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: lts/iron
+          node-version: lts/Hydrogen
       - run: npm ci
       - run: npm run build
       - id: originate-contracts-mondaynet

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v20
+v18
diff --git a/README.md b/README.md
@@ -41,7 +41,7 @@ Taquito currently supports the following versions of Node.js®:
 | ---------------- | ---------- |
 | v14 LTS          |    ❌      |
 | v16 LTS/Gallium  |    ❌      |
-| v18 LTS/Hydrogen |    ❌      |
+| v18 LTS/Hydrogen |    ✅      |
 | v20 LTS/Iron     |    ✅      |
 | v22              |    ✅      |
 

diff --git a/apps/taquito-test-dapp/package.json b/apps/taquito-test-dapp/package.json
@@ -1,7 +1,7 @@
 {
   "name": "taquito-test-dapp-vite",
   "private": true,
-  "version": "20.1.1",
+  "version": "20.1.2",
   "type": "module",
   "scripts": {
     "dev": "vite",
@@ -26,11 +26,11 @@
   "dependencies": {
     "@airgap/beacon-sdk": "^4.3.1",
     "@airgap/beacon-types": "^4.3.1",
-    "@taquito/beacon-wallet": "^20.1.1",
-    "@taquito/core": "^20.1.1",
-    "@taquito/taquito": "^20.1.1",
-    "@taquito/utils": "^20.1.1",
-    "@taquito/wallet-connect": "^20.1.1",
+    "@taquito/beacon-wallet": "^20.1.2",
+    "@taquito/core": "^20.1.2",
+    "@taquito/taquito": "^20.1.2",
+    "@taquito/utils": "^20.1.2",
+    "@taquito/wallet-connect": "^20.1.2",
     "buffer": "^6.0.3",
     "svelte-modals": "^2.0.0-beta.2",
     "svelte-select": "^5.8.3",

diff --git a/docs/contract-test-collection.md b/docs/contract-test-collection.md
@@ -1367,7 +1367,7 @@ license: MIT
 
 Transactions to smart contracts operate in the same fashion as transactions to an implicit account, the only difference being the `KT1...` address. You will also receive a transaction hash and have to wait for the transaction to be confirmed. Once confirmed, it can be the right time to update the user's/contract's balance, for example.
 
-Sending a transaction to a smart contract to update its storage will be a different type of action as it implies targetting a specific entrypoint and formatting correctly the data to be sent.
+Sending a transaction to a smart contract to update its storage will be a different type of action as it implies targeting a specific entrypoint and formatting correctly the data to be sent.
 
 Fortunately, Taquito will make this operation go like a breeze! First, you need the contract abstraction created with the address of the smart contract you are targeting:
 

diff --git a/docs/version.md b/docs/version.md
@@ -3,6 +3,16 @@ title: Versions
 author: Jev Bjorsell
 ---
 
+# Taquito v20.1.2
+## Summary
+
+### Node.js add support of v18
+There is a [node.js confirmed HTTP bug](https://github.com/nodejs/node/issues/47228) from v19 that occasionally causes HTTP requests to fail with a socket hang-up error.
+We decided to support node.js v18 again until this issue is resolved in the future node.js release #3098
+
+### Documentation
+Fixing typo #3094
+
 # Taquito v20.1.1
 ## Summary
 

diff --git a/example/package.json b/example/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@taquito/example",
   "private": true,
-  "version": "20.1.1",
+  "version": "20.1.2",
   "scripts": {
     "example": "node -r ts-node/register --preserve-symlinks example-node.ts",
     "example:activation": "node -r ts-node/register --preserve-symlinks example-activate.ts",
@@ -42,16 +42,16 @@
   },
   "dependencies": {
     "@ledgerhq/hw-transport-node-hid": "^6.29.5",
-    "@taquito/ledger-signer": "^20.1.1",
-    "@taquito/local-forging": "^20.1.1",
-    "@taquito/michel-codec": "^20.1.1",
-    "@taquito/michelson-encoder": "^20.1.1",
-    "@taquito/rpc": "^20.1.1",
-    "@taquito/sapling": "^20.1.1",
-    "@taquito/signer": "^20.1.1",
-    "@taquito/taquito": "^20.1.1",
-    "@taquito/tzip16": "^20.1.1",
-    "@taquito/utils": "^20.1.1",
+    "@taquito/ledger-signer": "^20.1.2",
+    "@taquito/local-forging": "^20.1.2",
+    "@taquito/michel-codec": "^20.1.2",
+    "@taquito/michelson-encoder": "^20.1.2",
+    "@taquito/rpc": "^20.1.2",
+    "@taquito/sapling": "^20.1.2",
+    "@taquito/signer": "^20.1.2",
+    "@taquito/taquito": "^20.1.2",
+    "@taquito/tzip16": "^20.1.2",
+    "@taquito/utils": "^20.1.2",
     "bignumber.js": "^9.1.2"
   },
   "devDependencies": {

diff --git a/integration-tests/data/metadataViews.ts b/integration-tests/data/metadataViews.ts
@@ -349,7 +349,7 @@ export const metadataViewsExample2 = {
 						},
 						code: [ { prim: 'CAR', args: [], annots: [] } ],
 						annotations: [
-							{ name: '%arg_zero', description: 'This is obvioulsy ignored.' },
+							{ name: '%arg_zero', description: 'This is obviously ignored.' },
 							{ name: '%arg_one', description: 'This is also ignored, but different.' },
 							{ name: '%arg_one_result', description: 'This is %arg_one on the resulting side.' },
 							{

diff --git a/integration-tests/data/smartpy-example-contract.ts b/integration-tests/data/smartpy-example-contract.ts
@@ -1,4 +1,4 @@
-// This contract code has storage,parameter,code but the Tezos RPC expects parmeter,code,storage
+// This contract code has storage,parameter,code but the Tezos RPC expects parameter,code,storage
 export const smartpySample = [{"prim":"storage","args":[
  {"prim":"nat"}]
 },

diff --git a/integration-tests/package.json b/integration-tests/package.json
@@ -13,26 +13,26 @@
     "originate-known-contracts": "node -r ts-node/register originate-known-contracts.ts",
     "originate-known-contracts-and-run-test": "node -r ts-node/register originate-known-contracts.ts && jest"
   },
-  "version": "20.1.1",
+  "version": "20.1.2",
   "dependencies": {
     "@ledgerhq/devices": "8.4.4",
     "@ledgerhq/hw-transport": "6.31.4",
     "@ledgerhq/hw-transport-node-hid": "6.29.5",
     "@ledgerhq/hw-transport-node-hid-noevents": "6.30.5",
-    "@taquito/contracts-library": "^20.1.1",
-    "@taquito/core": "^20.1.1",
-    "@taquito/http-utils": "^20.1.1",
-    "@taquito/local-forging": "^20.1.1",
-    "@taquito/michel-codec": "^20.1.1",
-    "@taquito/michelson-encoder": "^20.1.1",
-    "@taquito/remote-signer": "^20.1.1",
-    "@taquito/rpc": "^20.1.1",
-    "@taquito/sapling": "^20.1.1",
-    "@taquito/signer": "^20.1.1",
-    "@taquito/taquito": "^20.1.1",
-    "@taquito/tzip12": "^20.1.1",
-    "@taquito/tzip16": "^20.1.1",
-    "@taquito/utils": "^20.1.1",
+    "@taquito/contracts-library": "^20.1.2",
+    "@taquito/core": "^20.1.2",
+    "@taquito/http-utils": "^20.1.2",
+    "@taquito/local-forging": "^20.1.2",
+    "@taquito/michel-codec": "^20.1.2",
+    "@taquito/michelson-encoder": "^20.1.2",
+    "@taquito/remote-signer": "^20.1.2",
+    "@taquito/rpc": "^20.1.2",
+    "@taquito/sapling": "^20.1.2",
+    "@taquito/signer": "^20.1.2",
+    "@taquito/taquito": "^20.1.2",
+    "@taquito/tzip12": "^20.1.2",
+    "@taquito/tzip16": "^20.1.2",
+    "@taquito/utils": "^20.1.2",
     "bignumber.js": "^9.1.2",
     "bip39": "3.1.0",
     "blakejs": "^1.2.1"

diff --git a/lerna.json b/lerna.json
@@ -1,4 +1,4 @@
 {
   "useNx": true,
-  "version": "20.1.1"
+  "version": "20.1.2"
 }