-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quebec #3068
base: master
Are you sure you want to change the base?
Quebec #3068
Conversation
…vider for user query old block BREAKING CHANGE: PollingSubscribeProvider doesn't filter endorsement anymore and removed rpc entrypoints using param version 0 re #3036
…oved type PendingOperationsV1 BREAKING CHANGE: PendingOperationsQueryArguments.version used to accept 1 is removed for protocol q re #3034
A new deploy preview is available on Cloudflare Pages at https://11bb04aa.taquito-test-dapp.pages.dev |
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
Deploying taquito with Cloudflare Pages
|
…onfig for beta release
.github/workflows/main.yml
Outdated
env: | ||
# Ternary operator workaround | ||
TEZOS_RPC_${{ matrix.testnet_uppercase }}: ${{ github.event.pull_request.head.repo.fork && format('https://{0}.ecadinfra.com', matrix.testnet) || null }} | ||
TEZOS_RPC_${{ matrix.testnet_uppercase }}: ${{ github.event.pull_request.head.repo.fork && matrix.rpc_url || null }} | ||
# integration-tests-quebec-secret-key: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only use secret key script to develop when there is no keygen support yet in a new protocol, find it handy to have the script around but not necessary. I don't mind removing it if it's cleaner :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it cleaner to remove it, and we can always find it in the git history, but it is up to you :)
docs/rpc_nodes_integration_test.md
Outdated
@@ -8,120 +8,122 @@ author: Roxane Letourneau | |||
1. The RPC nodes' integration tests are disabled by default. | |||
Remove `./rpc-nodes.spec.ts` from `"testPathIgnorePatterns"` in the package.json. | |||
|
|||
**parisnet**: `npm run test:parisnet rpc-nodes.spec.ts` | |||
**parisnet**: `npm run test:quebecnet-secret-key integration-tests/__tests__/rpc/nodes.spec.ts` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should parisnet be replaced with quebecnet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes will update this, thank you!
@@ -2385,14 +2388,15 @@ export type LastRemovedCommitmentHashes = { | |||
}; | |||
|
|||
export interface PendingOperationsQueryArguments { | |||
version?: '1' | '2'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep '1' to stay compatible with precedent protocol?
…s to quebec on mainnet
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.