Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finding bluechi-image container #1002

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mwperina
Copy link
Member

@mwperina mwperina commented Dec 5, 2024

We have been using filters parameter for images.list() in podman-py
to search for bluechi-image container. But podman-py 5.3 changed the
behaviour of filters paramater as a part of
containers/podman-py#457 , so we need to use
name parameter for searching.

Signed-off-by: Martin Perina [email protected]

We have been using `filters` parameter for `images.list()` in podman-py
to search for bluechi-image container. But podman-py 5.3 changed the
behaviour of `filters` paramater as a part of
containers/podman-py#457 , so we need to use
`name` parameter for searching.

Signed-off-by: Martin Perina <[email protected]>
@mwperina mwperina force-pushed the fix-podman-py-5.3-issue branch from a40090f to eb9e3f0 Compare December 5, 2024 11:26
@coveralls
Copy link

Coverage Status

coverage: 81.201% (+0.1%) from 81.095%
when pulling eb9e3f0 on mwperina:fix-podman-py-5.3-issue
into fcaadfd on eclipse-bluechi:main.

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi engelmi merged commit 19b638a into eclipse-bluechi:main Dec 5, 2024
22 checks passed
Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina deleted the fix-podman-py-5.3-issue branch December 5, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants