-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Packit to handle downstream builds #1004
Conversation
Using |
I think this is a good first step towards automating releases for BlueChi. However, I have a few questions on how this works and fits into our release process: |
Yes.
No, Packit should do all the magic
No, Packit has the required permissions. There are more options that can be configured (e.g. trigger koji build also triggered by direct pushes to dist-git or merged PRs that were not created by Packit). But this configuration is a basic one and should do the trick for our (quite straightforward) process. Unfortunately there is no way to really test it without running an actual upstream release. But having this inside we can make sure it works when releasing 0.10. |
Where do we specify which tarball to use? Since we need git submodules for BlueChi, the default tarball created by GitHub doesn't contain these and the build would fail. We create a suitable tarball during the release pipeline. So we'd need to specify the tarball in the GH release as well as wait for the GH pipeline to finish.
So they use an account and everything on their side of the service.
Yes, lets see how it will work for the next release. We can still fallback to manual and refine this further. |
In the specfile:
Yes, you can look at qm releases - PRs in src.fedoraproject.com, koji builds and bodhi updates
Exactly |
Hmm, aren't we uploading this |
Yes, the default .tar.gz doesn't include the git submodules and we had to create it manually. This was automated a few months back and should work again (after the tokens were updated), see these CI steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would really like for @dougsland to review this one before we merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3a09c2f
to
63738a6
Compare
Adding configuration for Packit to: 1. Propose PR on src.fedoraproject.org triggered by release on GH 2. Once merged (and thus new commit created in dist-git) - Koji and Bodhi updates will be triggered. The .packit.yml configuration file should be updated in dist-git as well as part of the PR, so no need to create Packit configuration in dist git right now Signed-off-by: Mark Kemel <[email protected]>
Adding configuration for Packit to:
The .packit.yml configuration file should be updated in dist-git as well as part of the PR, so no need to create Packit configuration in dist git right now