Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for bluechi-is-online agent with --wait parameter #1013

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

DanaOrr
Copy link
Contributor

@DanaOrr DanaOrr commented Dec 17, 2024

Adding integration test for bluechi-is-online agent --wait with three tests:
Start agent and verify --wait option returns 0 immediately.
Stop agent and verify --wait returns 1 after wait time is expired.
Stop agent, run 'bluechi-is-online agent --wait' start agent and verify --wait returns 0 before the wait time expires.

Fixes: #1000
Signed-off-by: Dana Orr [email protected]

@coveralls
Copy link

coveralls commented Dec 18, 2024

Coverage Status

coverage: 82.356% (+1.3%) from 81.064%
when pulling 006739d on DanaOrr:bl-agent-with-wait
into d409ee5 on eclipse-bluechi:main.

@DanaOrr DanaOrr force-pushed the bl-agent-with-wait branch 3 times, most recently from 40a6398 to 0a59190 Compare December 18, 2024 12:59
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, but still some comments

1. Start agent and verify --wait option returns 0 immediately.
2. Stop agent and verify --wait returns 1 after wait time is expired.
3. Stop agent, run 'bluechi-is-online agent --wait' start agent and verify --wait returns 0 before the wait time expires.

Signed-off-by: Dana Orr <[email protected]>
@mkemel
Copy link
Member

mkemel commented Dec 23, 2024

/packit retest-failed

Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkemel mkemel requested a review from mwperina December 24, 2024 14:14
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkemel mkemel merged commit 7f73321 into eclipse-bluechi:main Dec 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for bluechi-is-online agent with --wait parameter
5 participants