-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for bluechi-is-online agent with --wait parameter #1013
Conversation
51f673b
to
8061142
Compare
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
8061142
to
9e07bab
Compare
40a6398
to
0a59190
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, but still some comments
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-agent-wait/test_bluechi_is_online_agent_wait.py
Outdated
Show resolved
Hide resolved
1. Start agent and verify --wait option returns 0 immediately. 2. Stop agent and verify --wait returns 1 after wait time is expired. 3. Stop agent, run 'bluechi-is-online agent --wait' start agent and verify --wait returns 0 before the wait time expires. Signed-off-by: Dana Orr <[email protected]>
0a59190
to
006739d
Compare
/packit retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding integration test for bluechi-is-online agent --wait with three tests:
Start agent and verify --wait option returns 0 immediately.
Stop agent and verify --wait returns 1 after wait time is expired.
Stop agent, run 'bluechi-is-online agent --wait' start agent and verify --wait returns 0 before the wait time expires.
Fixes: #1000
Signed-off-by: Dana Orr [email protected]