Add integration test for bluechi-is-online agent #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanaOrr
requested review from
alexlarsson,
engelmi,
mkemel and
rhatdan
as code owners
DanaOrr
force-pushed
the
bluechi-test-bluechi-is-online
branch
3 times, most recently
from
aa86714 to
75784a6
Compare
mwperina
requested changes
Dec 2, 2024
There was a problem hiding this comment.
You are almost there, great work!
Just some small comments
- Please add clear description to the commit message about the content of the commit. For example
- Adds bluechi_is_online module to provide bluechi-is-online methods to python code - Adds a test to verify `bluechi-is-online agent` invocation without additional parameters - Please refernce your issue in the commit description. For example
Fixes: https://github.com/eclipse-bluechi/bluechi/issues/981 Signed-off-by: Dana Orr <[email protected]>
tests/tests/tier0/bluechi-is-online-agent/test_bluechi_is_online_agent.py
Outdated
Show resolved
Hide resolved
DanaOrr
force-pushed
the
bluechi-test-bluechi-is-online
branch
3 times, most recently
from
7f0a89c to
f6dc589
Compare
- Adds bluechi_is_online module to provide bluechi-is-online methods to Python code. - Adds a test to verify `bluechi-is-online agent` invocation without additional parameters. Signed-off-by: Dana Orr <[email protected]>
DanaOrr
force-pushed
the
bluechi-test-bluechi-is-online
branch
from
f6dc589 to
fa7946f
Compare
|
Decreasing code coverage is caused by the fact, that previously source code for bluechi-is-online was not taken into account by coveralls (probably because bluechi-is-online was not invoked at all in any test and its source code is not used by other parts), so even though we have added new test, overall score was decreased. But that situation should be improving by adding more tests in upcoming PRs around bluechi-is-online |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test for bluechi-is-online agent.
'bluechi-is-online agent' command is verifying on the agent machine check and/or monitor the connection of the agent to the controller.
When the agent is online, it exits with a status code 0 and does not produce any CLI output.
Fixes: #981
Signed-off-by: Dana Orr [email protected]