This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
feat: Add an ability to pass editor description as URL to the generator #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <[email protected]>
Signed-off-by: Roman Nikitenko <[email protected]>
|
Click here to review and test in web IDE: |
Signed-off-by: Roman Nikitenko <[email protected]>
|
Click here to review and test in web IDE: |
RomanNikitenko
commented
Mar 1, 2023
| @@ -275,7 +275,7 @@ describe('Test Main with stubs', () => { | |||
| } catch (e) { | |||
| message = e.message; | |||
| } | |||
| expect(message).toEqual('missing editorPath or editorEntry or editorContent'); | |||
| expect(message).toEqual('missing editorPath or editorEntry or editorContent or editorUrl'); | |||
There was a problem hiding this comment.
The Jest is unhappy because of uncovered lines:
working on it, will update the PR soon...
RomanNikitenko
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
We need it for eclipse-che/che#18670
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.