GLSP-1438: Improve GLSPClient default implementations #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `onCurrentStateChanged` event for `GLSPClient` - Ensure that `start` and `initializeServer` behave as expected if they are called again while the previous promise is still pending. - Restructure members of the default implementations so that get/setters and their _property are grouped together - Introduce a dedicated namespace for the `Event` interface with utility functions to - listen on a certain event exactly once - waitUntil a certain event is fired the next time - Adapt test cases to verify new behavior Also: - Update `GLSPActionDispatcher` to use direct injection for registry instead of async provider
martin-fleck-at
approved these changes
Dec 6, 2024
2 tasks
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
+Fix eclipse-glsp#401 Node creation (eclipse-glsp#402) + Resolve eclipse-glsp#398 Refactor TypeHints API (eclipse-glsp#399) + Resolve eclipse-glsp#396 RouterKind for FeedbackEdge (eclipse-glsp#397) + Reuse Sprotty's request/response system and remove custom solution(eclipse-glsp#404) + Add support for context menu and harmonize with command palette (eclipse-glsp#405)
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
+Fix eclipse-glsp#401 Node creation (eclipse-glsp#402) + Resolve eclipse-glsp#398 Refactor TypeHints API (eclipse-glsp#399) + Resolve eclipse-glsp#396 RouterKind for FeedbackEdge (eclipse-glsp#397) + Reuse Sprotty's request/response system and remove custom solution(eclipse-glsp#404) + Add support for context menu and harmonize with command palette (eclipse-glsp#405)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
onCurrentStateChangedevent forGLSPClientstartandinitializeServerbehave as expected if they are called again while the previous promise is still pending.Eventinterface with utility functions toAlso:
GLSPActionDispatcherto use direct injection for registry instead of async providerHow to test
Follow-ups
Changelog