Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1116 Revise model loading #178

Merged
merged 2 commits into from
Sep 20, 2023
Merged

GLSP-1116 Revise model loading #178

merged 2 commits into from
Sep 20, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Sep 12, 2023

Adapt codebase to client changes for eclipse-glsp/glsp/issues/1116

Requires eclipse-glsp/glsp-client#287

GLSP-1071: Rename ServerStatus/ServerMessage action
Part of eclipse-glsp/glsp/issues/1071

@tortmayr tortmayr requested a review from planger September 12, 2023 15:13
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍
I didn't have the chance to test that thoroughly yet, however, we do some more indepth testing before the release anyway, so I don't want to block testing everything in combination once merged.

@tortmayr
Copy link
Contributor Author

@planger I have also added change for GLSP-1117 and GLSP-1071 to this PR. Since these are also changes that require updatse across all integration projects I would rather do this all in one go instead of having to create multiple PRs per repository.

Could you please re-review?

Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr merged commit 6608c4f into master Sep 20, 2023
4 checks passed
@tortmayr tortmayr deleted the glsp-1116 branch June 17, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants