GLSP-1041: Fix connection to JavaServer via websocket #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `websocket-connection-forwarder´ to send messages via websockets as decoded strings instead of buffers. Althoug the websocket protocol supports both string and buffer messages the java implementation is only capable of handling string messages. Fixes eclipse-glsp/glsp#1041 # Update to latest client version Adapt code base to conform to changes for eclipse-glsp/glsp-client#288 # Also - Ensure that the diagramDiContainer gets unloaded when the widget is disposed. (This trigger dispose functionality defiend in th diagram container (e.g. methods annoted with @preDestroy) -Align name of `notification-module` directory wither other feature root dirs (=> notification) Requires eclipse-glsp/glsp-client#288
tortmayr
force-pushed
the
update-client
branch
from
9dd6270 to
af75ed4
Compare
tortmayr
changed the title
martin-fleck-at
approved these changes
Sep 21, 2023
tortmayr
force-pushed
the
update-client
branch
from
af75ed4 to
682e6a5
Compare
tortmayr
force-pushed
the
update-client
branch
from
682e6a5 to
5965d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLSP-1041: Fix connection to JavaServer via websocket
Update `websocket-connection-forwarder´ to send messages via websockets as decoded strings
instead of buffers. Althoug the websocket protocol supports both string and buffer messages the java
implementation is only capable of handling string messages.
Fixes eclipse-glsp/glsp#1041
Update to latest client version
Adapt code base to conform to changes for eclipse-glsp/glsp-client#288
Also
-Align name of
notification-moduledirectory wither other feature root dirs (=> notification)Requires eclipse-glsp/glsp-client#288