Skip to content

Commit

Permalink
Update commit requirements in Contributing page.
Browse files Browse the repository at this point in the history
Removing the 'Signed-off-by' requirement as it isn't listed in the
Eclipse Project Handbook anymore.

Signed-off-by: Carsten Lohmann <[email protected]>
  • Loading branch information
calohmn committed Sep 29, 2023
1 parent 00a508e commit 1f493b8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 15 deletions.
10 changes: 3 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,10 @@ electronically sign the Eclipse Contributor Agreement (ECA).

* http://www.eclipse.org/legal/ECA.php

Commits that are provided by non-committers must have a Signed-off-by field in
the footer indicating that the author is aware of the terms by which the
contribution has been provided to the project. The non-committer must
additionally have an Eclipse Foundation account and must have a signed Eclipse
Contributor Agreement (ECA) on file.
Authors who are not committers on the project receiving the commit must have an Eclipse Foundation Account
and must have a signed Eclipse Contributor Agreement (ECA) on file.

For more information, please see the Eclipse Committer Handbook:
For more information, please see the Eclipse Project Handbook:
https://www.eclipse.org/projects/handbook/#resources-commit

## Making your Changes
Expand All @@ -41,7 +38,6 @@ https://www.eclipse.org/projects/handbook/#resources-commit
* Use descriptive and meaningful commit messages. In particular, start the first line of the commit message with the
number of the issue that the commit addresses, e.g. `[#9865] Add token based authentication.`
* Squash multiple commits that are related to each other semantically into a single one
* Make sure you use the `-s` flag when committing as explained above
* Push your changes to your branch in your forked repository

## Submitting the Changes
Expand Down
12 changes: 4 additions & 8 deletions site/homepage/content/community/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,10 @@ electronically sign the Eclipse Contributor Agreement (ECA).

* http://www.eclipse.org/legal/ECA.php

Commits that are provided by non-committers must have a Signed-off-by field in
the footer indicating that the author is aware of the terms by which the
contribution has been provided to the project. The non-committer must
additionally have an Eclipse Foundation account and must have a signed Eclipse
Contributor Agreement (ECA) on file.
Authors who are not committers on the project receiving the commit must have an Eclipse Foundation Account
and must have a signed Eclipse Contributor Agreement (ECA) on file.

For more information, please see the Eclipse Committer Handbook:
For more information, please see the Eclipse Project Handbook:
https://www.eclipse.org/projects/handbook/#resources-commit

## Conventions
Expand Down Expand Up @@ -73,8 +70,7 @@ https://www.eclipse.org/projects/handbook/#resources-commit
9. Commit your changes into your *feature branch*.
10. Use descriptive and meaningful commit messages.
11. Squash multiple commits related to the same feature/issue into a single one, if reasonable.
12. Make sure you use the `-s` flag when committing in order to add a *Signed-off-by* footer as mentioned above.
13. Push your changes to your branch in your forked repository.
12. Push your changes to your branch in your forked repository.

## Submitting the Changes

Expand Down

0 comments on commit 1f493b8

Please sign in to comment.