[#3557] Implement LoRa Actility triangulated device location support #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harism Thanks for the PR. @BobClaerhout Do you have any comments on this? |
no remarks from me. LGTM |
sophokles73
added
enhancement
Feature Request
calohmn
reviewed
Oct 4, 2023
...s/lora/src/main/java/org/eclipse/hono/adapter/lora/providers/ActilityEnterpriseProvider.java
Show resolved
Hide resolved
harism
changed the title
|
@calohmn I created an issue and tried to link its id to my commit and this PR, also I changed those years as you requested. But the copyright holders list modification, I noticed that there is an open question about those here; #3554 (comment) -- and I am wondering is this totally fundamental step or not? |
I will to discuss this with the Eclipse Foundation but for the time being, it is ... |
sophokles73
approved these changes
Oct 7, 2023
|
I modified the legal/NOTICE.md now too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for device triangulated location in Hono LoRa adapter for Actility. The added location information is described in the Thingpark Wireless documentation; https://docs.thingpark.com/thingpark-wireless/6.1/Content/Resources/DocLibrary/TP-Wireless-6.0-LRC-OSS%20Interface%20Developer%20Guide(LoRaWAN).pdf (page 15)
The same documentation should apply also to Thingpark Enterprise specification and optional fields DevLAT, DevLON and DevAlt should be present in that adapter too.