Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse can't build when error in switch #2887

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

srikanth-sankaran
Copy link
Contributor

@srikanth-sankaran srikanth-sankaran commented Sep 3, 2024

What it does

Eclipse can't build when error in switch

Author checklist

@mpalat
Copy link
Contributor

mpalat commented Sep 4, 2024

@srikanth-sankaran can you please make the following changes:
in org.eclipse.jdt.core.compiler.batch/pom.xml , please make version 3.39.100
also in org.eclipse.jdt.core.tests.compiler - pom.xml, please make version - 600 instead of 500
eg - 53874f9

@srikanth-sankaran srikanth-sankaran force-pushed the GH2870 branch 5 times, most recently from ed8a766 to effeafd Compare September 5, 2024 09:06
@srikanth-sankaran
Copy link
Contributor Author

With the changes proposed for this PR, the tests are green, but locally we see an error The minor version should be incremented in version 3.39.100, since new APIs have been added since version 3.39.0 - In discussion with @jarthana (and in his discussions with @vik-chand) it looks like this is a defect in PDE. @jarthana will follow up with a defect report

@iloveeclipse
Copy link
Member

This is being discussed here : eclipse-pde/eclipse.pde#1386
It is a PDE bug...
Workaround for now: close org.eclipse.jdt.core.tests.builder.mockcompiler project and clean build jdt.core.

@srikanth-sankaran srikanth-sankaran merged commit d83efba into eclipse-jdt:master Sep 5, 2024
9 checks passed
@srikanth-sankaran srikanth-sankaran deleted the GH2870 branch September 11, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eclipse can't build when error in switch
3 participants