Fix adding null annotation to qualified type of parameter #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix NullAnnotationsRewriteOperations.ParameterAnnotationRewriteOperation to check for a SimpleType with qualified name or a NameQualifiedType and end up with a NameQualifiedType with the new annotation added - add new tests to NullAnnotationsQuickFixTest - fixes eclipse-jdt#1462
jjohnstn
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes the quick fix to change a parameter to add nullable annotation so that if the parameter type is qualified, it creates or modifies a NameQualifiedType reference and adds the annotation before the simple name (e.g.
int foo(java.io @Nullable PrintStream) {...How to test
See original issue or new tests.
Author checklist