Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotateAssistTest1d8 test failed #1478

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

stephan-herrmann
Copy link
Contributor

addresses the ClassCastException

fixes #736

addresses the ClassCastException

fixes eclipse-jdt#736
@stephan-herrmann
Copy link
Contributor Author

@iloveeclipse @jjohnstn From 3 attempts I got 2 timeouts (and one unrelated intermittent failure).

Who decides about the timeout? It seems that the current limit of 40 min. is not realistic.

@iloveeclipse
Copy link
Member

Who decides about the timeout? It seems that the current limit of 40 min. is not realistic.

See

timeout(time: 40, unit: 'MINUTES')

@stephan-herrmann
Copy link
Contributor Author

Who decides about the timeout? It seems that the current limit of 40 min. is not realistic.

See

timeout(time: 40, unit: 'MINUTES')

Thanks, so the timeout has been at 40 since @ktatavarthi created that file 2 years ago (#1)

Asked differently: does everybody think this is the right threshold?

@stephan-herrmann stephan-herrmann merged commit fafdd0e into eclipse-jdt:master Jun 26, 2024
9 checks passed
@stephan-herrmann stephan-herrmann deleted the issue736 branch June 26, 2024 15:53
@akurtakov
Copy link
Contributor

Looking at https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/master/buildTimeTrend - normal build is usually around ~25 minutes. What we see is probably related to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4063#note_2472456 . Meanwhile it should be fine to bump it to e.g. 60 minutes (twice slower than average time) so people don't have to restart builds like that.

@stephan-herrmann
Copy link
Contributor Author

Looking at https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/master/buildTimeTrend - normal build is usually around ~25 minutes. What we see is probably related to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4063#note_2472456 . Meanwhile it should be fine to bump it to e.g. 60 minutes (twice slower than average time) so people don't have to restart builds like that.

Thanks, will do if/when I run into this problem again in the near future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnnotateAssistTest1d8 test failed
3 participants