dogfooding - Convert String concatenation to Text Block #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstenartur
force-pushed
the
Convert_String_concatenation_to_Text_Block
branch
2 times, most recently
from
e6bfe92 to
d799b8c
Compare
carstenartur
force-pushed
the
Convert_String_concatenation_to_Text_Block
branch
2 times, most recently
from
7977acf to
c5589fb
Compare
carstenartur
force-pushed
the
Convert_String_concatenation_to_Text_Block
branch
from
c5589fb to
a44b9be
Compare
carstenartur
force-pushed
the
Convert_String_concatenation_to_Text_Block
branch
from
a44b9be to
fa677a2
Compare
carstenartur
force-pushed
the
Convert_String_concatenation_to_Text_Block
branch
from
fa677a2 to
dae414f
Compare
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a run of the "Convert String concatenation to Text Block" cleanup without the option for "Stringbuffer" on jdt.ui (only runtime modules, no test code). With the "Stringbuffer" option we run into some errors unfortunately, there is a bug.
Since the JDT UI modules now are higher than Java 15 we can make use of it.
What it does
By using text blocks the code gets more readable and the formating characters like return get translated.
How to test
Nothing should be changed because of this. Tests should run through as before and everywhere you should see Strings in the same way as before. Just check an arbitrary text block where it appears in the resulting ice.
Author checklist