Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch insertSpaces and tabSize options from the client preferences #1551

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fetch insertSpaces and tabSize options from the client preferences #1551

merged 1 commit into from
Feb 25, 2021

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Sep 21, 2020 •
edited by fbricon
Loading

Relates to redhat-developer/vscode-java#1572

Signed-off-by: Snjezana Peco [email protected]

@snjeza snjeza requested review from gorkem and fbricon September 21, 2020 18:31
@snjeza snjeza mentioned this pull request Sep 21, 2020
Merged
@snjeza
Copy link
Contributor Author

snjeza commented Sep 21, 2020

Related issue - redhat-developer/vscode-java#557

@snjeza
Copy link
Contributor Author

snjeza commented Sep 22, 2020

@fbricon I have updated the PR.

@fbricon fbricon mentioned this pull request Sep 25, 2020
Open
fbricon
fbricon requested changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of things I'd also like to see moved around. I made snjeza#2 to give you an idea

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/PreferenceManager.java Outdated Show resolved Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java Outdated Show resolved Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java Outdated Show resolved Hide resolved
@snjeza
Copy link
Contributor Author

snjeza commented Sep 25, 2020

There's a bunch of things I'd also like to see moved around. I made snjeza#2 to give you an idea

I have updated the PR.

@snjeza
Copy link
Contributor Author

snjeza commented Sep 27, 2020

@fbricon I have updated the PR.

@jdneo
Copy link
Contributor

jdneo commented Sep 30, 2020

Hi @snjeza，

Will you fetch the client side format setting through the server request workspace/configuration? (#1194)

@snjeza
Copy link
Contributor Author

snjeza commented Sep 30, 2020

Will you fetch the client side format setting through the server request workspace/configuration? (#1194)

I will try.

@testforstephen testforstephen mentioned this pull request Nov 26, 2020
Merged
@jdneo jdneo mentioned this pull request Nov 26, 2020
Closed
@testforstephen testforstephen mentioned this pull request Feb 22, 2021
Merged
@testforstephen
Copy link
Contributor

@snjeza could you rebase and resolve the conflicts?

@snjeza
Copy link
Contributor Author

snjeza commented Feb 24, 2021

@snjeza could you rebase and resolve the conflicts?

Done.

@testforstephen testforstephen changed the title Surround with try/catch reformats document Fetch insertSpaces and tabSize options from the client preferences Feb 24, 2021
@testforstephen testforstephen added this to the End February milestone Feb 25, 2021
@testforstephen testforstephen merged commit f667fb5 into eclipse-jdtls:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon requested changes

@testforstephen testforstephen testforstephen approved these changes

@gorkem gorkem Awaiting requested review from gorkem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
End February 2021
Development

Successfully merging this pull request may close these issues.
4 participants
@snjeza @jdneo @testforstephen @fbricon