Avoid unnecessary project updates when the default vm changes #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this PR, I no longer see project update notifications when I reload eclipse.jdt.ls. The language server ready time can be dropped from 1min20s to 40s. The default vm change from vscode-pde doesn't force update eclipse.jdt.ls projects. |
testforstephen
requested review from
snjeza,
rgrunber,
jdneo,
fbricon and
CsCherrYY
snjeza
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of the issue #1960, the reason is that JDT triggers unnecessary update with the default vm change. (See the analysis from the PR #1961).
See the TODO in the following snippet, we should trigger project update only if the project importer uses the default vm.
https://github.com/eclipse/eclipse.jdt.ls/blob/f8452b422add64f9bbc80d0e22b48ed71797e563/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JVMConfigurator.java#L305-L309
Since the Eclipse and Maven project importer doesn't depend on the default vm, I changed it to only trigger update for gradle projects. Also, see the earliest PR #1430 that introduced this snippet, where it exactly is used to solve gradle import issue.