Improve performance of code actions, and certain delegate commands #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snjeza
requested review from
gorkem,
fbricon,
rgrunber,
jdneo and
testforstephen
rgrunber
reviewed
Aug 21, 2023
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java
Outdated
Show resolved
Hide resolved
rgrunber
reviewed
Aug 21, 2023
| // see https://github.com/eclipse-jdtls/eclipse.jdt.ls/issues/2799 | ||
| // Handle the paste event synchronously in the main thread | ||
| if (IDelegateCommandHandler.JAVA_EDIT_HANDLE_PASTE_EVENT.equals(params.getCommand())) { | ||
| Object result = commandHandler.executeCommand(params, new NullProgressMonitor()); |
There was a problem hiding this comment.
Is your thinking here that it's pointless to report progress on the paste event ? I kind of agree. I know we don't currently report progress to the client for delegates via progress support but we may implement it in the future.
rgrunber
reviewed
Aug 21, 2023
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java
Outdated
Show resolved
Hide resolved
|
@rgrunber I have updated the PR. |
rgrunber
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Inspecting this in VisualVM I see :
After the threads are able to acquire the lock, they each hit the monitor.isCancelled() and it ends there. This is probably better than having them all run.
Can you modify the commit message to :
Improve performance of code actions, and certain delegate commands
- Handle paste event & smart semicolon detection synchronously (main thread)
- Permit only a single code action to be handled at once
- Handle paste event & smart semicolon detection synchronously (main thread) - Permit only a single code action to be handled at once A related issue - eclipse-jdtls#2799 Signed-off-by: Snjezana Peco <[email protected]>
I have modified it. |
rgrunber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2799
Fixes redhat-developer/vscode-java#3199