Skip to content

Commit

Permalink
Add "--pinentry-mode loopback" to gpg
Browse files Browse the repository at this point in the history
  • Loading branch information
jonahgraham committed Dec 5, 2024
1 parent 54b0fc5 commit c8ccd36
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 5 deletions.
4 changes: 2 additions & 2 deletions documentation/releasing.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Items at the beginning of development
- [ ] Check [CHANGELOG.md](https://github.com/eclipse-lsp4j/lsp4j/blob/main/CHANGELOG.md) is up to date. The changelog should have a version entry, release date, API Breakages and other information consistent with current entries in the changelog.
- [ ] Check [README.md](https://github.com/eclipse-lsp4j/lsp4j/blob/main/README.md) is up to date. In particular that the planned release and which versions of DAP and LSP are support is listed.
- [ ] Increment version of all feature.xml, pom.xml and any other place full version is used. (Easiest way is global find and replace, e.g. `s/0.23.0/0.24.0/g`, `s/0.22.0/0.23.0/g` and review changes.) Ensure that `-SNAPSHOT` is restored in the [gradle/versions.gradle](https://github.com/eclipse-lsp4j/lsp4j/blob/main/gradle/versions.gradle) and [releng/pom.xml](https://github.com/eclipse-lsp4j/lsp4j/blob/main/releng/pom.xml)
- [ ] Enable `sh './releng/deploy-build.sh'` in [releng/build.Jenkinsfile](https://github.com/eclipse-lsp4j/lsp4j/blob/main/releng/build.Jenkinsfile)
- [ ] Enable `cd releng && ./deploy-build.sh'` in [releng/build.Jenkinsfile](https://github.com/eclipse-lsp4j/lsp4j/blob/main/releng/build.Jenkinsfile)
- [ ] Ensure [the CI build](https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/main/) is stable - it is always better to release a "Green Dot" build

Items in the days ahead of Release day:
Expand All @@ -30,7 +30,7 @@ Items on Release day:
- [ ] Prepare the repo for release by:
- [ ] removing `-SNAPSHOT` from [gradle/versions.gradle](https://github.com/eclipse-lsp4j/lsp4j/blob/main/gradle/versions.gradle)
- [ ] removing `-SNAPSHOT` from [releng/pom.xml](https://github.com/eclipse-lsp4j/lsp4j/blob/main/releng/pom.xml) entries in `<dependencies>` section.
- [ ] disabling `sh './releng/deploy-build.sh'` in [releng/build.Jenkinsfile](https://github.com/eclipse-lsp4j/lsp4j/blob/main/releng/build.Jenkinsfile)
- [ ] disabling `cd releng && ./deploy-build.sh'` in [releng/build.Jenkinsfile](https://github.com/eclipse-lsp4j/lsp4j/blob/main/releng/build.Jenkinsfile)
- see commit https://github.com/eclipse-lsp4j/lsp4j/commit/328ce8a4c89b0cd84fb62118f459b6cf79b09e90 for a past example
- [ ] Push the above change
- [ ] Run [the CI build](https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/main/)
Expand Down
2 changes: 1 addition & 1 deletion releng/build.Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ pipeline {
// XXX: Can release vs snapshot be detected automatically so that
// the following line does not have to be commented/uncommented
// on each change to/from SNAPSHOT?
sh './releng/deploy-build.sh'
sh 'cd releng && ./deploy-build.sh'
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions releng/deploy-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ $SSH mv ${DOWNLOAD_MOUNT}-new ${DOWNLOAD_MOUNT}
case $BRANCH_NAME in
main | release_*)
# GPG Sign and Deploy to Maven Central snapshot
find build/maven-repository -name '*.pom' | while read i
find ../build/maven-repository -name '*.pom' | while read i
do
base="${i%.*}"
# See https://wiki.eclipse.org/Jenkins#How_can_artifacts_be_deployed_to_OSSRH_.2F_Maven_Central.3F for more info
# on the Eclipse Foundation specific settings.
mvn -X \
mvn -X -f gpgparameters.pom \
org.apache.maven.plugins:maven-gpg-plugin:3.2.7:sign-and-deploy-file \
-DpomFile=${base}.pom \
-Dfile=${base}.jar \
Expand Down
30 changes: 30 additions & 0 deletions releng/gpgparameters.pom
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>org.eclipse.lsp4j</groupId>
<artifactId>gpgparameters</artifactId>
<version>0.24.0-SNAPSHOT</version>
<packaging>pom</packaging>

<!--
This file is used to pass command line parameters to GPG because there is no user
property that can be used. See depoy-build.sh
-->

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>3.2.7</version>
<configuration>
<gpgArguments>
<arg>--pinentry-mode</arg>
<arg>loopback</arg>
</gpgArguments>
</configuration>
</plugin>
</plugins>
</build>
</project>

0 comments on commit c8ccd36

Please sign in to comment.