Modernize Gradle #781
Merged
Modernize Gradle #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: what about ide task |
cdietrich
force-pushed
the
cd_issue776
branch
from
c3c7a35 to
5f05cee
Compare
Merged
cdietrich
force-pushed
the
cd_issue776
branch
3 times, most recently
from
9efccb0 to
5ea1173
Compare
|
I'm looking at this now. I think this is fine and we'll leave the bnd upgrade to 7.0 (with its Java 17 requirement) for another day. |
Signed-off-by: Christian Dietrich <[email protected]> fix some gradle deprecations Signed-off-by: Christian Dietrich <[email protected]> update to gradle 8.5 Signed-off-by: Christian Dietrich <[email protected]> downgrade bnd plugin again Signed-off-by: Christian Dietrich <[email protected]>
cdietrich
force-pushed
the
cd_issue776
branch
from
5ea1173 to
e034d59
Compare
|
ok i have rebase rebased and squashed. lets see what build says |
|
@jonahgraham ok to merge before the release? |
I will review the generated poms/jars to make sure no unexpected changes and I will merge when/if I approve soon. |
|
opk. cause i need to drop off soon |
jonahgraham
approved these changes
Feb 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #776