broaden gson range, bundle new gson and guava #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
szarnekow
approved these changes
May 21, 2024
|
As a client of lsp4j I'd even consider using a 3.0 as the exclusive upper bound of the dependency. |
We got (minorly) burned a while ago because a new version of gson didn't strictly follow semantic versioning. Ever since then I have been concerned to not have a runtime problem. However I am asked multiple times for this, so seeing as many consumers seem ok with the (minor) risk, I say lets widen it up.
Yes |
jonahgraham
reviewed
May 21, 2024
(squash this before merge)
|
Can you merge am afk |
jonahgraham
added a commit
to jonahgraham/lsp4j
that referenced
this pull request
May 21, 2024
Fixes eclipse-lsp4j#836 Signed-off-by: Christian Dietrich <[email protected]> Co-authored-by: Jonah Graham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonahgraham do we need a dot release for simrel?