Fix for API error on SWT on 4.34 master #1387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveeclipse
force-pushed
the
issue_1386
branch
from
a9cd097 to
5c28c5b
Compare
Don't try to add EE to bundles that don't have any requirements defined in manifest. ManifestUtils.getRequiredExecutionEnvironments() currently returns "generic" bundle runtime requirements from OSGI for bundles that don't define anything, and it seem to be violation of the org.osgi.framework.wiring.BundleRevision.getDeclaredRequirements(String) contract that isn't supposed to return anything if nothing is specified in the manifest. At least for API baseline tooling use of OSGI generic requirements not specified in the manifest do not make sense, as we compare what's written in the manifest and not what is derived from the platform or host. Fixes eclipse-pde#1386
iloveeclipse
force-pushed
the
issue_1386
branch
from
5c28c5b to
84827f7
Compare
|
Obsolete with #1395, thank you nevertheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to add EE to bundles that don't have any requirements defined in manifest.
ManifestUtils.getRequiredExecutionEnvironments() currently returns "generic" bundle runtime requirements from OSGI for bundles that don't define anything, and it seem to be violation of the org.osgi.framework.wiring.BundleRevision.getDeclaredRequirements(String) contract that isn't supposed to return anything if nothing is specified in the manifest.
At least for API baseline tooling use of OSGI generic requirements not specified in the manifest do not make sense, as we compare what's written in the manifest and not what is derived from the platform or host.
Fixes #1386