IApiAnnotations.isExact for CompositeApiDescription.resolveAnnotations

[merks]

• CompositeApiDescription.resolveAnnotations should be able to properly find the best match annotation using IApiAnnotations.isExact which is now also implemented by TypeAnnotations.isExact.

#1386

[github-actions]

Test Results

   283 files   -   2     283 suites   - 2   53m 44s ⏱️ -57s
 3 580 tests ±  0   3 503 ✅  -   1   77 💤 + 1  0 ❌ ±0 
10 766 runs   - 166  10 563 ✅  - 138  203 💤  - 28  0 ❌ ±0 

Results for commit 15bf1d1. ± Comparison against base commit 7c21dfb.

This pull request skips 1 test.

org.eclipse.pde.build.internal.tests.p2.P2Tests ‑ offBug237662

♻️ This comment has been updated with latest results.

[iloveeclipse]

I've just rebased on master to have the fix for API filter warning

[merks]

I see. The test were all green?

[iloveeclipse]

I see. The test were all green?

Yes, I just dislike merging PR's with partially red state.

[iloveeclipse]

I've tried the patch and I can confirm it solves the jdt.core problem.

So if I understood it correct, the regression was in 40cf1f0 as the code checked for the annotation to be instanceof ApiAnnotations and of course TypeAnnotations weren't but should be (from very beginning probably).

[iloveeclipse]

Many thanks Ed!

[HannesWell]

Thank you Ed for this.

So if I understood it correct, the regression was in 40cf1f0 as the code checked for the annotation to be instanceof ApiAnnotations and of course TypeAnnotations weren't but should be (from very beginning probably).

I wonder how this can be unnoticed for four years? :O