Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scanoss bundling #434

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: scanoss bundling #434

merged 1 commit into from
Dec 19, 2024

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Dec 18, 2024

What it does

scanoss depends on node-fetch <3. node-fetch in that version fails their instance checks, as it relies on constructor/class names which are removed by the backend bundling.

Customizes the webpack configurations to keep the class name for 'AbortSignal' as this is the one failing the check.

How to test

Build the Browser and/or Electron production builds and make sure that SCANOSS keeps working.

Review checklist

Reminder for reviewers

scanoss depends on node-fetch <3. node-fetch in that version fails
their instance checks, as it relies on constructor/class names which
are removed by the backend bundling.

Customizes the webpack configurations to keep the class name for
'AbortSignal' as this is the one failing the check.
@tsmaeder
Copy link
Contributor

From the code, this looks good to me. @sdirix were you able to test this locally? Also, we should remove the "patch" this PR applies to the generated webpack config when we consume a version that contains eclipse-theia/theia#14650

@sdirix
Copy link
Member Author

sdirix commented Dec 19, 2024

Also, we should remove the "patch" this PR applies to the generated webpack config when we consume a version that contains eclipse-theia/theia#14650

We can only remove this patch for the Browser variant. In the Electron variant we already overwrote the TerserPlugin, so our additional customization must still be kept.

From the code, this looks good to me. @sdirix were you able to test this locally?

Yes I tested the production variants of Browser, Electron and packaged Electron (Linux AppImage) and all of them worked for me.

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, AppImage and Docker Container work for me

Copy link
Contributor

@JonasHelming JonasHelming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfaltermeier We should trigger a patch release now

@jfaltermeier jfaltermeier merged commit bf1a479 into master Dec 19, 2024
5 checks passed
@sdirix sdirix deleted the sdirix/fix-scanoss branch December 19, 2024 07:26
@sdirix
Copy link
Member Author

sdirix commented Dec 19, 2024

@jfaltermeier @JonasHelming, @tsmaeder is encountering another issue. Maybe it's because he is on a Windows machine. Let's quickly verify before we do the release. See here.

@sdirix
Copy link
Member Author

sdirix commented Dec 19, 2024

The Windows issue was fixed here: eclipse-theia/theia#14653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants