-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: scanoss bundling #434
Conversation
scanoss depends on node-fetch <3. node-fetch in that version fails their instance checks, as it relies on constructor/class names which are removed by the backend bundling. Customizes the webpack configurations to keep the class name for 'AbortSignal' as this is the one failing the check.
From the code, this looks good to me. @sdirix were you able to test this locally? Also, we should remove the "patch" this PR applies to the generated webpack config when we consume a version that contains eclipse-theia/theia#14650 |
We can only remove this patch for the Browser variant. In the Electron variant we already overwrote the
Yes I tested the production variants of Browser, Electron and packaged Electron (Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, AppImage and Docker Container work for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfaltermeier We should trigger a patch release now
@jfaltermeier @JonasHelming, @tsmaeder is encountering another issue. Maybe it's because he is on a Windows machine. Let's quickly verify before we do the release. See here. |
The Windows issue was fixed here: eclipse-theia/theia#14653 |
What it does
scanoss depends on
node-fetch
<3
. node-fetch in that version fails their instance checks, as it relies on constructor/class names which are removed by the backend bundling.Customizes the webpack configurations to keep the class name for 'AbortSignal' as this is the one failing the check.
How to test
Build the Browser and/or Electron production builds and make sure that SCANOSS keeps working.
Review checklist
Reminder for reviewers