-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: incorporate Q-Gate Review #389
Chore: incorporate Q-Gate Review #389
Conversation
…ced rest to DEV docs
Hey @evegufy, created a PR that tried to address nearly all findings including recommendations (helm restrucutre not yet included). I also added the arm64 architecture and it seems that in the run there is an issue with dependent libraries. Did you maybe also face something similar? We're using a separate npm task to perform a build for docker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good in general!
Just some comments:
- I attempted to execute a
helm upgrade
and noticed that you currently need the set flags from here for that to work...
if you just add empty""
here and here as value you spare those set flags. I really recommend to change that, otherwise executing an upgrade is not intuitive. - please also name the secret for the postgres dependency more uniquely https://github.com/eclipse-tractusx/puris/blob/2.0.0/charts/puris/values.yaml#L501, for instance
secret-puris-postgres-init
…le names are correct
Additionally did the following:
Thanks a lot @evegufy for supporting me on this! |
Description
Fix findings from QGate:
As I was already in the mood:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: