Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dashboard): add button to schedule erp update manually #504

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Jul 16, 2024

Description

solves #490 by adding a button to the dashboard view allowing users to schedule the item stock update for what they currently see:

  • customer or supplier tab defines the direction
  • partner = the one associated with the selected sites (mutliple schedules)
  • material = the one selected

beside that I added notifications for the async tasks (schedule erp update, trigger refersh of partner data) in the dashboard view -> solve #414

Note on helm version: keep it as 2.7.0 as it's the next unreleased minor version.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Contributor

@eschrewe eschrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much, Only the chart version needs to be incremented ;)

@tom-rm-meyer-ISST
Copy link
Contributor Author

LGTM, thank you very much, Only the chart version needs to be incremented ;)

@eschrewe thanks for reviewing! I won't bump the chart version as we currently have not yet released a new version (current is puris-2.6.3). In the past we didn't release each chart bump and only bumped the chart as it has been blocking. The workflow is meant for real devOps (each commit = new release) which we don't follow (also due to splitting PRs to smaller ones). Recent pratice actually lead to some version gaps in the released charts (not smart from my side).

I removed the setting, that the chart is blocking but keep it failing indicating that the reviewer needs to check if nevertheless the increase is needed e.g.: we already increased the chart version to a patch level in a previous change. The chart has not yet been released. In the next pr we have a minor level change in the chart -> now we should increase the chart version to the next minor.

Sidenote: also our PR template now has a new box indicating this helm chart check :)

@eschrewe eschrewe self-requested a review July 18, 2024 07:55
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the failed pipeline has already been discussed.

@mhellmeier mhellmeier merged commit a7c7e04 into eclipse-tractusx:main Jul 18, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants