Unix Domain Socket support with JDK16+ #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still a draft PR, the doc must be updated. |
|
Also, waiting for #5320 to be merged before updating |
tsegismont
force-pushed
the
jdk-domain-socket
branch
from
a8acd73 to
a454e56
Compare
|
@vietj I've rebased the PR, since you have merged #5320 already. For the docs, I'm inclined to:
Fine with you? |
|
@tsegismont makes sense |
vietj
reviewed
Oct 18, 2024
vertx-core/src/main/java/io/vertx/core/impl/transports/UnixDomainSocketJdkSupport.java
Outdated
Show resolved
Hide resolved
tsegismont
force-pushed
the
jdk-domain-socket
branch
from
a454e56 to
ad60628
Compare
|
@vietj the doc has been updated and the PR is now ready for review. |
|
@tsegismont can you rebase on latest master ? |
Since Netty 4.1.110.Final, Unix Domain Sockets are available with NIO transport. https://netty.io/news/2024/05/22/4-1-110-Final.html This changes the Vert.x JDKTransport to support Unix Domain Sockets without native transports when a JDK16+ is used. Signed-off-by: Thomas Segismont <[email protected]>
Signed-off-by: Thomas Segismont <[email protected]>
Removed the domain sockets section nested in native transports. Added examples of domain socket client/server in both the net.adoc and http.adoc files, with a reference to the native transports section for those who don't use JDK 16 and above. Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
force-pushed
the
jdk-domain-socket
branch
from
ad60628 to
f51fed0
Compare
Done |
vietj
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Netty 4.1.110.Final, Unix Domain Sockets are available with NIO transport. https://netty.io/news/2024/05/22/4-1-110-Final.html
This changes the Vert.x JDKTransport to support Unix Domain Sockets without native transports when a JDK16+ is used.