Drop usage of partial byte buf allocator. #5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
suggested changes
Nov 6, 2024
Motivation: Vert.x partial byte buf allocator implies the usage of unpooled buffers which can lead to increase significantly the memory footprint for SSL. Changes: Delete the partial byte buf allocator and use instead the same allocator than the non SSL case.
vietj
force-pushed
the
remove-partial-allocator
branch
from
a14d29e to
559ac46
Compare
franz1981
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Vert.x partial byte buf allocator implies the usage of unpooled buffers which can lead to increase significantly the memory footprint for SSL.
Changes:
Delete the partial byte buf allocator and use instead the same allocator than the non SSL case.