Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JsonArray contains for non-wrapped JsonArray/JsonObject #5414

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

kristian
Copy link
Contributor

@kristian kristian commented Dec 3, 2024

Fixes #5397 for 4.x

@vietj
Copy link
Member

vietj commented Dec 4, 2024

@kristian can you check ? the code does not compile

@kristian kristian force-pushed the fix/jsonarraycontains4 branch from 1854df7 to cf0ac28 Compare December 4, 2024 08:55
@kristian
Copy link
Contributor Author

kristian commented Dec 4, 2024

@vietj sorry forgot that 4.x compiles with Java 8. It's fixed now.

@vietj vietj merged commit e5fe823 into eclipse-vertx:4.x Dec 5, 2024
7 checks passed
@vietj
Copy link
Member

vietj commented Dec 5, 2024

awesome @kristian , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants