packages/nixos: write Kata agent output to console and journal #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we only wrote Kata agent output to the console / TTY (which is also what it does upstream [^1]). This makes the output appear in the Kata runtime logs on the Host via the `vmconsole=` field. However, when debugging from within the pod VM, it's helpful to also have the logs in there so that they can be searched in with `journalctl`. This makes it so the output of the agent is written to both the console _and_ the journal. [^1]: https://github.com/kata-containers/kata-containers/blob/3.10.1/src/agent/kata-agent.service.in
|
what does the |
My idea was to mark each PR that originates from the |
|
If things depend on each other, please base dependent branches on the PR they depend on. Otherwise I don't see how this is helpful. |
They don't depend on each other, so I've just removed the mark. |
msanft
changed the title
burgerdev
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only wrote Kata agent output to the console / TTY (which is also what it does upstream 1). This makes the output appear in the Kata runtime logs on the Host via the
vmconsole=field. However, when debugging from within the pod VM, it's helpful to also have the logs in there so that they can be searched in withjournalctl. This makes it so the output of the agent is written to both the console and the journal.Footnotes
https://github.com/kata-containers/kata-containers/blob/3.10.1/src/agent/kata-agent.service.in ↩