attestation: add name to Validator as unique identifier #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmxnzo
force-pushed
the
logging/attestation-jla
branch
from
c5805b5 to
dde0de0
Compare
jmxnzo
changed the title
jmxnzo
force-pushed
the
logging/attestation-jla
branch
from
dde0de0 to
e243f98
Compare
|
Wait for merge of #1082 |
…tor as unique identifier
jmxnzo
force-pushed
the
logging/attestation-jla
branch
from
e243f98 to
98e66b7
Compare
burgerdev
reviewed
Dec 20, 2024
burgerdev
reviewed
Dec 20, 2024
katexochen
reviewed
Dec 23, 2024
| @@ -248,7 +250,7 @@ func verifyEmbeddedReport(validators []Validator, cert *x509.Certificate, peerPu | |||
| return nil | |||
| } | |||
| // Otherwise, we'll keep track of the error and continue with the next validator. | |||
| retErr = errors.Join(retErr, fmt.Errorf("validator %s failed: %w", validator.OID(), validationErr)) | |||
| retErr = errors.Join(retErr, fmt.Errorf(" validator %s failed: %w ||", validator.String(), validationErr)) | |||
There was a problem hiding this comment.
Suggested change
| retErr = errors.Join(retErr, fmt.Errorf(" validator %s failed: %w ||", validator.String(), validationErr)) | |
| retErr = errors.Join(retErr, fmt.Errorf(" validator %s failed: %w", validator.String(), validationErr)) |
There was a problem hiding this comment.
Imo, the double dash serves better readability of the joined error, because we have no specific formatting implemented for now. But i can drop this, if it seems unnecessary.
There was a problem hiding this comment.
errors are already joined using newlines: https://cs.opensource.google/go/go/+/refs/tags/go1.23.4:src/errors/join.go;l=52-54
adding custom formatting here isn't idiomatic
| @@ -260,6 +262,11 @@ func verifyEmbeddedReport(validators []Validator, cert *x509.Certificate, peerPu | |||
| return ErrNoMatchingValidators | |||
| } | |||
|
|
|||
| // The joined error should reveal the atls nonce once to maintain readability. | |||
| if retErr != nil { | |||
| retErr = fmt.Errorf("AtlsConnectionNonce: %s || %w", hex.EncodeToString(nonce), retErr) | |||
There was a problem hiding this comment.
Suggested change
| retErr = fmt.Errorf("AtlsConnectionNonce: %s || %w", hex.EncodeToString(nonce), retErr) | |
| retErr = fmt.Errorf("with AtlsConnectionNonce %s: %w", hex.EncodeToString(nonce), retErr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on #1027 and aims to enhance the logging of the different validation processes on the coordinator to reach better readability of the logs.
<attestation>-<reference-values-index>[-<product>]The index corresponds to the position of the reference value separated by attestation type in manifest.json.