e2e: allow usage of different PatchManifestFunc + add test for equal WorkloadSecretID #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estFunc for modification
jmxnzo
force-pushed
the
e2e/workload-secrets-jla
branch
from
9f01b81 to
379e448
Compare
jmxnzo
changed the title
jmxnzo
changed the title
katexochen
reviewed
Dec 27, 2024
| type PatchManifestFunc func(*manifest.Manifest, platforms.Platform, ...interface{}) | ||
|
|
||
| // PatchManifest modifies the current manifest by executing a provided PatchManifestFunc on it. | ||
| func (ct *ContrastTest) PatchManifest(t *testing.T, platform platforms.Platform, patchFn PatchManifestFunc, args ...interface{}) { |
There was a problem hiding this comment.
This isn't a good design, as you loose type safety if your argument(s) have type interface{}/any.
Better use
type PatchManifestFunc func(manifest.Manifest) manifest.ManifestAs patch func. You can either declare patchReferenceValues inline in the test (if it is only used once) or write a func that takes the args and returns type PatchManifestFunc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the patchManifest() method in contrasttest.go to allow executing variadic PatchManifestFunc on the current manifest, which obtain different modifications.