Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDMP-632 - Batch should be a subclass of Constituent rather than Product #485

Closed
ElisaKendall opened this issue Sep 25, 2023 · 3 comments
Closed
Assignees
Labels
invalid This doesn't seem right
Milestone

Comments

@ElisaKendall
Copy link
Contributor

A batch is a constituent of a product, not a product in its own right. This should be corrected in the ontology. The same is true of Lot. A lot should be a subclass of constituent rather than product.

@ElisaKendall ElisaKendall added the invalid This doesn't seem right label Sep 25, 2023
@ElisaKendall ElisaKendall self-assigned this Sep 25, 2023
@tw-osthus
Copy link
Contributor

I am not so sure. It is more a collection then a constituent. A batch is a collection of goods produced at the same time. The same is lot, which is a collection of goods sold as one item.

In chemistry, it is important to distinguish between batch production and continuous production. If we define product as material that is being produced (so not necessary sold which is good), then subclassing from product is correct.

@ElisaKendall
Copy link
Contributor Author

@tw-osthus I'm not sure who raised this in one of our Monday meetings - it was one of the pharma companies I think. I've asked Johnson & Johnson how they represent it - we can confirm the approach on Monday next week before we finalize the release.

@mereolog mereolog added this to the Release 0.5.0 milestone Sep 29, 2023
@ElisaKendall
Copy link
Contributor Author

This has been merged via pull request #486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants