Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDMP-632 - Batch should be a subclass of Constituent rather than Product #486

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

ElisaKendall
Copy link
Contributor

Description: Revised the inheritance for Batch and Lot to subclass constituent rather than product

…tituent rather than product

Signed-off-by: Elisa Kendall <[email protected]>
@ElisaKendall ElisaKendall added the invalid This doesn't seem right label Sep 25, 2023
@ElisaKendall ElisaKendall self-assigned this Sep 25, 2023
@tw-osthus
Copy link
Contributor

see my #485

Copy link
Contributor

@tw-osthus tw-osthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure.
A product is matter that is being produced. A batch is a collection of things being produced at the same time. This makes batch a collection, not a constituent, and I do not see, why it is not a product. It is not necessarily a good, because the batch is not always sold as such. A lot is a collection of things that are sold together as one item, again not constituent.

@ElisaKendall
Copy link
Contributor Author

I am not sure. A product is matter that is being produced. A batch is a collection of things being produced at the same time. This makes batch a collection, not a constituent, and I do not see, why it is not a product. It is not necessarily a good, because the batch is not always sold as such. A lot is a collection of things that are sold together as one item, again not constituent.

@tw-osthus I'm not sure who raised this in one of our Monday meetings - it was one of the pharma companies I think. I've asked Johnson & Johnson how they represent it - we can confirm the approach on Monday next week before we finalize the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants