Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDMP-655 - Revise the Commons ontologies and related changes for Commons 1.1 #476

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

ElisaKendall
Copy link
Contributor

@ElisaKendall ElisaKendall commented Sep 20, 2023

Description:

  1. Integrate updated dates and times ontology, which adds concepts including time period, explicit time period, and a number of properties (monotonically - i.e., in a backwards compatible way with the prior version,
  2. Integrate changes to the Documents ontology, including addressing some of the simplifications made by OMG, such as moving Specification to the top of the class hierarchy, renaming isSpecifiedBy to isSpecifiedIn, and so forth,
  3. Integrate changes to the QuantitiesAndUnits ontology to rename 'Quantity' to 'ScalarQuantity', 'QuantityValue' to 'ScalarQuantityValue' and 'QuantityValueRange' to 'ScalarQuantityValueRange' in anticipation of integrating tensor and vector quantities in 2024,
  4. Renamed the Composites ontology to RolesAndCompositions per the latest update to the Commons library (no semantic changes, strictly ontology prefix and IRI)

…cepts including time period, explicit time period, and a number of properties (monotonically - i.e., in a backwards compatible way with the prior version

Signed-off-by: Elisa Kendall <[email protected]>
@ElisaKendall ElisaKendall added enhancement New feature or request CMNS labels Sep 20, 2023
@ElisaKendall ElisaKendall self-assigned this Sep 20, 2023
ElisaKendall and others added 5 commits September 20, 2023 15:43
…ons 1.1 revision, which simplifies some constructs, such as Specification, moving it to the top level rather than as a subclass of arrangement, refines definitions, adds examples and sources for definitions, and eliminates reporting related concepts, which may be included in a separate ontology in a subsequent revision

Signed-off-by: Elisa Kendall <[email protected]>
… 'ScalarQuantityValue', and 'QuantityValueRange' to 'ScalarQuantityValueRange' per the revisions made by OMG in the Commons 1.1 revision to the Quantities and Units ontology

Signed-off-by: Elisa Kendall <[email protected]>
…r the latest update to the Commons library (no semantic changes, strictly ontology prefix and IRI)

Signed-off-by: Elisa Kendall <[email protected]>
@mereolog mereolog added this to the Release 0.5.0 milestone Sep 21, 2023
@mereolog mereolog changed the title IDMP-655 - Revise the Commons ontologies and related changes for Commons 1.1 (WIP) IDMP-655 - Revise the Commons ontologies and related changes for Commons 1.1 Sep 21, 2023
@tw-osthus
Copy link
Contributor

constant and variables should not be limited to scalar quantity values according to their definitions. If the formula and expression is a vector formula, then constants and variables are not limited to scalars.

Copy link
Contributor

@tw-osthus tw-osthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quantities and measures ontology seems to be incomplete or even inconsistent with regards to notes and definitions

@@ -72,18 +73,18 @@
<rdfs:label>agent</rdfs:label>
<rdfs:seeAlso rdf:datatype="&xsd;anyURI">http://www.jamesodell.com/WhatIsAnAgent.pdf</rdfs:seeAlso>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

www.jamesodell.com is no longer available on the web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw-osthus I'll raise an issue to revise the link, then. He certainly was when we did the original work for FIBO, and has been a long time participant in an Agents and Events metamodel effort at OMG that is still poking along.

@@ -125,7 +127,7 @@
</owl:Class>

<owl:Class rdf:about="&cmns-qtu;Constant">
<rdfs:subClassOf rdf:resource="&cmns-qtu;QuantityValue"/>
<rdfs:subClassOf rdf:resource="&cmns-qtu;ScalarQuantityValue"/>
<rdfs:label>constant</rdfs:label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are constants limited to scalars?
In vector formulas, constants are most likely vectors too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw-osthus We made those changes because we have work planned to bring in vector and tensor quantities at the higher level, and so we didn't want to cause too much downstream churn once those additions are made. The work is based on the new SysML v2 library for quantities and units, which we are doing at OMG in conjunction with the European Space Agency, a number of US and EU government and military organizations, NASA/JPL, and many others such as John Deere, Boeing, and Airbus. Several of them suggested the name change for now so that once we add the more complex content we limit churn in the ontology. Hope that makes sense.

<dct:source>ISO 11240 Health informatics - Identification of medicinal products - Data elements and structures for the unique identification and exchange of units of measurement, clause 3.1.24</dct:source>
<dct:source>ISO 80000-1:2009 Quantities and units - Part 1: General, clause 3.1</dct:source>
<dct:source rdf:datatype="&xsd;anyURI">https://www.omg.org/spec/SysML/</dct:source>
<skos:definition>property of a phenomenon, body, or substance, where the property has a magnitude that can be expressed by means of a number and a reference</skos:definition>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition is unclear.
Is the velocity when I walk in a northern direction a scalar quantity?

6 * km/h * = number (6) times scalar reference velocity / measurement unit (km/h) times Northern direction

Is north-velocity a scalar quantity because the reference includes the vector?
or is there only a vector quantity because the magnitude is always a scalar as in ISO 80000?
What about tensors?

Should there be a definition for quantity?
What is a vector quantity?
What is a tensor quantity?

Velocity should be a vector quantity because it is directional in classical space (it is AFAIK a tensor in relativistic space).
but its direction independent magnitude is a scalar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw-osthus Extensions for tensors and vectors are planned (actually in work) for sometime in the first half of next year.

@ElisaKendall
Copy link
Contributor Author

constant and variables should not be limited to scalar quantity values according to their definitions. If the formula and expression is a vector formula, then constants and variables are not limited to scalars.

@tw-osthus See my comment about adding a much richer representation for tensor and vector quantities over the next several months. The intent is to create a small ontology defining arrays, tensors and vectors, and to reuse that in an extension to the quantities and units ontology to enable representation of tensor and vector related quantities. The current model doesn't support them, so we changed the names to minimize the amount of change needed later and to be clear about what this version of the ontology covers.

@ElisaKendall
Copy link
Contributor Author

constant and variables should not be limited to scalar quantity values according to their definitions. If the formula and expression is a vector formula, then constants and variables are not limited to scalars.

@tw-osthus They are not limited - we have not built those out yet ... waiting to have the complete set of units before we generate a library of the most common ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMNS enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants