Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IRIs in transformation scripts #484

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Update IRIs in transformation scripts #484

merged 3 commits into from
Sep 25, 2023

Conversation

mereolog
Copy link
Contributor

This addresses the issue raised in #471 (comment), which makes the GSRS validation unit tests fail.

@mereolog mereolog self-assigned this Sep 25, 2023
@mereolog mereolog marked this pull request as ready for review September 25, 2023 20:08
ElisaKendall
ElisaKendall approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@ElisaKendall ElisaKendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me.

@ElisaKendall ElisaKendall merged commit ba9f260 into master Sep 25, 2023
@mereolog mereolog deleted the update_iris_in_transformation_scripts branch September 28, 2023 11:44
@mereolog mereolog added this to the Release 0.5.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliariff aliariff aliariff approved these changes

@ElisaKendall ElisaKendall ElisaKendall approved these changes

@tw-osthus tw-osthus Awaiting requested review from tw-osthus

@Heiner-Oberkampf Heiner-Oberkampf Awaiting requested review from Heiner-Oberkampf

Assignees

@mereolog mereolog

Labels
GSRS v3.0.3 unit test
Projects
None yet
Milestone
Release 0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mereolog @ElisaKendall @aliariff