IDMP-592 - Complete the preliminary modeling work required for Nucleic Acid, covering all detail provided in ISO 11238 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id sequence type per the ISO specification Signed-off-by: Elisa Kendall <[email protected]>
…ization Signed-off-by: Elisa Kendall <[email protected]>
…cid classifier, completing the attributes of the nucleic acid class Signed-off-by: Elisa Kendall <[email protected]>
Signed-off-by: Elisa Kendall <[email protected]>
Signed-off-by: Elisa Kendall <[email protected]>
…ment and revised restriction on nucleic acid Signed-off-by: Elisa Kendall <[email protected]>
…leic acid subunit, completing the properties needed to represent the subunit Signed-off-by: Elisa Kendall <[email protected]>
…perties Signed-off-by: Elisa Kendall <[email protected]>
… subunit Signed-off-by: Elisa Kendall <[email protected]>
Signed-off-by: Elisa Kendall <[email protected]>
…eeded for sugar Signed-off-by: Elisa Kendall <[email protected]>
…substance' and 'is related substance to' to allow for molecular entities in addition to physical substances; added supports and is supported by, linked nucleic acid subunits to sugars via is supported by per email interchange with SMEs Signed-off-by: Elisa Kendall <[email protected]>
…s (its inverse) to relate a linkage to a nucleic acid subunit Signed-off-by: Elisa Kendall <[email protected]>
…'sugar' per SME input Signed-off-by: Elisa Kendall <[email protected]>
ElisaKendall
changed the title
mereolog
requested changes
Sep 28, 2023
ISO/ISO11238-Substances.rdf
Outdated
Comment on lines
6747
to
6757
| <owl:DatatypeProperty rdf:about="&idmp-sub;hasSequenceAttachment"> | ||
| <rdfs:subPropertyOf rdf:resource="&cmns-dsg;isDescribedBy"/> | ||
| <rdfs:label>has sequence attachment</rdfs:label> | ||
| <rdfs:range rdf:resource="&cmns-doc;Reference"/> | ||
| <skos:definition>provides an 'enriched' string, a document or image representing the sequence</skos:definition> | ||
| <idmp-sub:hasBusinessRules>The element Sequence is always mandatory; the element Sequence Attachment may be provided based on jurisdictional guidance. Either the sequence is provided as ST or/and as an attachment as ED.</idmp-sub:hasBusinessRules> | ||
| <idmp-sub:hasConformanceLevel rdf:resource="&idmp-sub;ConformanceLevel-Conditional"/> | ||
| <idmp-dtp:isEncodedAs rdf:resource="&idmp-dtp;DatatypeCode-ED"/> | ||
| <cmns-av:adaptedFrom>ISO/TS 19844:2018(E) Health informatics - Identification of medicinal products (IDMP) - Implementation guidelines for ISO 11238 for data elements and structures for the unique identification and exchange of regulated information on substances, clause 7.3 and Figure 27</cmns-av:adaptedFrom> | ||
| <cmns-av:directSource>ISO 11238:2018 Health informatics - Identification of medicinal products (IDMP) - Data elements and structures for the unique identification and exchange of regulated information on substances, clause 7.5</cmns-av:directSource> | ||
| </owl:DatatypeProperty> |
There was a problem hiding this comment.
hasSequenceAttachment is declared as a datatype property, but its range is an OWL class, which "makes" it an object property. Since the latter is an instance of illegal punning, we need to do something about it.
tw-osthus
previously requested changes
Sep 28, 2023
| <cmns-av:directSource>ISO 11238:2018 Health informatics - Identification of medicinal products (IDMP) - Data elements and structures for the unique identification and exchange of regulated information on substances, clause 7.5</cmns-av:directSource> | ||
| </owl:ObjectProperty> | ||
|
|
||
| <owl:ObjectProperty rdf:about="&idmp-sub;hasFivePrimeSubstanceName"> |
There was a problem hiding this comment.
Why do we need "has related substance name"/"has reltated substance identifier" and their subproperties, when it is enough to have "has related substance/has substance name". If we want to refer from the nucleic acid to the sugar, a property "has sugar" as subclass of has related substance or has moiety make more sense to me.
Referencing to related entities via ids or names is relational modeling, not graph based modeling.
The 3/5 prime and sugar are moieties or constituents of the nucleic acid.
There was a problem hiding this comment.
@tw-osthus I thought about that, but there are specific queries that may be easier with explicit properties, and the standard requires it. Thus, we've used property chains, to connect through the substance to its name or identifier here.
Signed-off-by: Elisa Kendall <[email protected]>
avilesg
approved these changes
Sep 28, 2023
mereolog
approved these changes
Sep 29, 2023
mereolog
dismissed
tw-osthus’s stale review
We should prepare for the incoming release next week, so the issues raised in the review may be discussed afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: