Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDMP-638 add package item type #489

Merged
merged 5 commits into from
Oct 2, 2023
Merged

IDMP-638 add package item type #489

merged 5 commits into from
Oct 2, 2023

Conversation

tw-osthus
Copy link
Contributor

Description: add package item type as classifier for package items

@tw-osthus tw-osthus changed the title IDMP-638 add package item type (WIP) IDMP-638 add package item type Sep 28, 2023
Copy link
Contributor

@mereolog mereolog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Running test              : [If we refer to something, it should have a type]
	ERROR:https://spec.pistoiaalliance.org/idmp/ontology/ISO/EuropeanJurisdiction/SubstancesProductsOrganisationsReferentials/Domain-HumanAndVetinaryUse is referenced by hasSPORDomain but has no type.
	ERROR:https://spec.pistoiaalliance.org/idmp/ontology/ISO/EuropeanJurisdiction/SubstancesProductsOrganisationsReferentials/DataClassification-Public is referenced by hasSPORDataClassification but has no type.
	ERROR:https://spec.pistoiaalliance.org/idmp/ontology/ISO/EuropeanJurisdiction/SubstancesProductsOrganisationsReferentials/DataClassification-Public is referenced by hasSPORVisibility but has no type.
   errors count per test  :	3
 - Running test              : [If we refer to something, it should have a type]
	ERROR: Property https://spec.pistoiaalliance.org/idmp/ontology/ISO/EuropeanJurisdiction/SubstancesProductsOrganisationsReferentials/hasSPORIdentifier is used but has no type.
	ERROR: Property https://spec.pistoiaalliance.org/idmp/ontology/ISO/EuropeanJurisdiction/SubstancesProductsOrganisationsReferentials/hasSPORDataClassification is used but has no type.
   errors count per test  :	2

@tw-osthus tw-osthus requested a review from mereolog September 29, 2023 09:19
Copy link
Contributor

@ElisaKendall ElisaKendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this given the changes that have been made.

@mereolog mereolog merged commit 6369958 into master Oct 2, 2023
6 checks passed
@mereolog mereolog deleted the IDMP-638 branch October 13, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants