Effekt versions should be compared loosely

effekt-lang · Aug 10, 2024 · 9f2a545 · 9f2a545
1 parent 8d1abde
commit 9f2a545
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/effektManager.ts b/src/effektManager.ts
@@ -111,7 +111,8 @@ export class EffektManager {
             const currentVersion = await this.execCommand(`"${effektPath}" --version`);
             const latestVersion = await this.getLatestNPMVersion(this.effektNPMPackage);
 
-            if (semver.gt(latestVersion, semver.clean(currentVersion) || '')) {
+            // check if the latest version strictly newer than the current version
+            if (semver.gt(latestVersion, semver.clean(currentVersion, true) || '', true)) {
                 return this.promptForAction(latestVersion, 'update');
             }
 

diff --git a/src/semver.d.ts b/src/semver.d.ts
@@ -1,5 +1,5 @@
 declare module 'semver' {
-    export function gt(v1: string, v2: string): boolean;
-    export function lt(v1: string, v2: string): boolean;
-    export function clean(v: string): string | null;
+    export function gt(v1: string, v2: string, loose?: boolean): boolean;
+    export function lt(v1: string, v2: string, loose?: boolean): boolean;
+    export function clean(v: string, loose?: boolean): string | null;
 }