-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Effekt Version Manager: automatic installer and updater #20
Merged
Merged
Changes from 22 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
b5d95c1
[WIP] Automatic installer
jiribenes 5cfd08b
Refactor updater&installer into separate file
jiribenes 170cd03
Attempt to backport changes
jiribenes 3c78bb9
Nicer error logging
jiribenes 2fbf610
Refactor, add doc comments
jiribenes 961b251
Re-add node&npm version check
jiribenes ffc5696
Try to fix CI by bumping node
jiribenes a121fb1
Add 'restartServer' command, refactor cmds
jiribenes 6f43974
Refactor, rename
jiribenes 0c7ebe4
Rudimentary error handling in commands
jiribenes 8253e4a
Effekt versions should be compared loosely
jiribenes cbc37e8
Click on status bar item to check for updates
jiribenes 440a6da
Add more sofisticated tooltip with current version
jiribenes 898b460
[WIP] Add installation verification
jiribenes 1390d5e
Fix type mismatch when checking effekt version
jiribenes 39d41c3
Migrate to 'compare-versions' instead of 'node-semver'
jiribenes 8c91f4f
Try to use more descriptive function names
jiribenes 2d4fe4d
Parse Effekt version properly
jiribenes aa52545
Try to handle unknown Effekt version when updating
jiribenes 79e0e0b
Don't compare missing version
jiribenes 8d11e78
Add Java (JRE) detection
jiribenes 58a759d
Detect older versions of Effekt via a hack
jiribenes ceb9c1b
Fix Java version detection
jiribenes 7f227b3
Remove misleading message about PATH.
jiribenes 7a3a837
Force 'execCommand' to use utf8 and to have max 1MB buffer
jiribenes 297b738
Refactor ci.yml
jiribenes 25fac57
Auto-format
jiribenes 8a32b5d
Fix spurious 'Effekt is not installed' message when refusing to update
jiribenes b3d30d0
Experimental Nix-managed NPM detection for better errors
jiribenes b7551fb
Update minimum NodeJS version
jiribenes 71ae96e
Fix LSP on Windows (#25)
jiribenes 36d28ee
On Windows, try 'effekt.cmd' first
jiribenes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,34 @@ | ||
| // A launch configuration that compiles the extension and then opens it inside a new window | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "Extension", | ||
| "type": "extensionHost", | ||
| "request": "launch", | ||
| "runtimeExecutable": "${execPath}", | ||
| "args": [ | ||
| "--extensionDevelopmentPath=${workspaceFolder}" | ||
| ], | ||
| "outFiles": [ | ||
| "${workspaceFolder}/out/**/*.js" | ||
| ], | ||
| "preLaunchTask": "npm: watch" | ||
| }, | ||
| { | ||
| "name": "Extension Tests", | ||
| "type": "extensionHost", | ||
| "request": "launch", | ||
| "runtimeExecutable": "${execPath}", | ||
| "args": [ | ||
| "--extensionDevelopmentPath=${workspaceFolder}", | ||
| "--extensionTestsPath=${workspaceFolder}/out/test" | ||
| ], | ||
| "outFiles": [ | ||
| "${workspaceFolder}/out/test/**/*.js" | ||
| ], | ||
| "preLaunchTask": "npm: watch" | ||
| } | ||
| ] | ||
| } | ||
| "configurations": [ | ||
| { | ||
| "type": "extensionHost", | ||
| "request": "launch", | ||
| "name": "Launch Client", | ||
| "runtimeExecutable": "${execPath}", | ||
| "args": ["--extensionDevelopmentPath=${workspaceRoot}"], | ||
| "outFiles": [ | ||
| "${workspaceRoot}/client/out/**/*.js", | ||
| "${workspaceRoot}/server/out/**/*.js" | ||
| ], | ||
| "autoAttachChildProcesses": true, | ||
| "preLaunchTask": { | ||
| "type": "npm", | ||
| "script": "watch" | ||
| } | ||
| }, | ||
| { | ||
| "name": "Language Server E2E Test", | ||
| "type": "extensionHost", | ||
| "request": "launch", | ||
| "runtimeExecutable": "${execPath}", | ||
| "args": [ | ||
| "--extensionDevelopmentPath=${workspaceRoot}", | ||
| "--extensionTestsPath=${workspaceRoot}/client/out/test/index", | ||
| "${workspaceRoot}/client/testFixture" | ||
| ], | ||
| "outFiles": ["${workspaceRoot}/client/out/test/**/*.js"] | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,8 @@ | ||
| // Place your settings in this file to overwrite default and user settings. | ||
| { | ||
| "files.exclude": { | ||
| "out": false // set this to true to hide the "out" folder with the compiled JS files | ||
| }, | ||
| "search.exclude": { | ||
| "out": true // set this to false to include "out" folder in search results | ||
| }, | ||
| "cSpell.words": [ | ||
| "alt", | ||
| "bitbucket", | ||
| "bytecode", | ||
| "classpath", | ||
| "ctrl", | ||
| "jvm", | ||
| "languageclient", | ||
| "minijava", | ||
| "mj", | ||
| "org", | ||
| "p", | ||
| "prettysourcetree", | ||
| "prettytree", | ||
| "sbegin", | ||
| "sourcetree", | ||
| "sstart", | ||
| "targettree", | ||
| "tbegin", | ||
| "tsc", | ||
| "tstart", | ||
| "usr" | ||
| ] | ||
| "editor.insertSpaces": false, | ||
| "typescript.tsc.autoDetect": "off", | ||
| "typescript.preferences.quoteStyle": "single", | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.eslint": "explicit" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,33 @@ | ||
| // See https://go.microsoft.com/fwlink/?LinkId=733558 | ||
| // for the documentation about the tasks.json format | ||
| { | ||
| "version": "2.0.0", | ||
| "tasks": [ | ||
| { | ||
| "type": "npm", | ||
| "script": "watch", | ||
| "problemMatcher": "$tsc-watch", | ||
| "isBackground": true, | ||
| "presentation": { | ||
| "reveal": "never" | ||
| }, | ||
| "group": { | ||
| "kind": "build", | ||
| "isDefault": true | ||
| } | ||
| } | ||
| ] | ||
| "version": "2.0.0", | ||
| "tasks": [ | ||
| { | ||
| "type": "npm", | ||
| "script": "compile", | ||
| "group": "build", | ||
| "presentation": { | ||
| "panel": "dedicated", | ||
| "reveal": "never" | ||
| }, | ||
| "problemMatcher": [ | ||
| "$tsc" | ||
| ] | ||
| }, | ||
| { | ||
| "type": "npm", | ||
| "script": "watch", | ||
| "isBackground": true, | ||
| "group": { | ||
| "kind": "build", | ||
| "isDefault": true | ||
| }, | ||
| "presentation": { | ||
| "panel": "dedicated", | ||
| "reveal": "never" | ||
| }, | ||
| "problemMatcher": [ | ||
| "$tsc-watch" | ||
| ] | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does everybody suddenly start to use tabs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually took these files from the VSCode template extension, just to update the structure :)