-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sprinkler-rain-grass model to probabilistic #43
base: master
Are you sure you want to change the base?
Conversation
@mm0821 Sorry for not merging right-away! Is this still up-to-date? |
That's my fault. I marked it as draft, since I wanted to check whether I could simplify some comments (they are quite verbose in parts) or maybe even convert this into a case study. But I never found the time. It's quite old and I have to recheck whether it still works with the current version of Effekt. |
This should work with the (my) current Effekt version now. I guess the check here failed because the new syntax for block parameters is not yet supported on this branch (as it is quite a bit behind 😄). You can merge it, if you like. I don't know when I will have time to revise it and I fear will forget about it again... |
@b-studios Now that there are great case studies for probabilistic programming in Effekt, it is probably not necessary to turn this into a case study (I will likely forget about it anyway). Thus, you can just merge it, in case you want to keep it as a somewhat more elaborated example for testing, or otherwise just close the PR. |
4633fa1
to
28ed63d
Compare
I think it is value to keep this. I rebased and updated the comment syntax. |
ee9d209
to
58c8510
Compare
No description provided.