Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sprinkler-rain-grass model to probabilistic #43

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

mm0821
Copy link
Contributor

@mm0821 mm0821 commented Jan 5, 2021

No description provided.

@mm0821 mm0821 marked this pull request as draft January 7, 2021 00:55
@b-studios
Copy link
Collaborator

@mm0821 Sorry for not merging right-away! Is this still up-to-date?

@mm0821
Copy link
Contributor Author

mm0821 commented Nov 7, 2022

That's my fault. I marked it as draft, since I wanted to check whether I could simplify some comments (they are quite verbose in parts) or maybe even convert this into a case study. But I never found the time. It's quite old and I have to recheck whether it still works with the current version of Effekt.

@mm0821
Copy link
Contributor Author

mm0821 commented Nov 7, 2022

This should work with the (my) current Effekt version now. I guess the check here failed because the new syntax for block parameters is not yet supported on this branch (as it is quite a bit behind 😄).

You can merge it, if you like. I don't know when I will have time to revise it and I fear will forget about it again...

@mm0821
Copy link
Contributor Author

mm0821 commented Apr 25, 2024

@b-studios Now that there are great case studies for probabilistic programming in Effekt, it is probably not necessary to turn this into a case study (I will likely forget about it anyway). Thus, you can just merge it, in case you want to keep it as a somewhat more elaborated example for testing, or otherwise just close the PR.

@mm0821 mm0821 marked this pull request as ready for review April 25, 2024 20:07
@b-studios
Copy link
Collaborator

I think it is value to keep this. I rebased and updated the comment syntax.

@jiribenes jiribenes force-pushed the master branch 3 times, most recently from ee9d209 to 58c8510 Compare October 1, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants